From e5036fe823acaffe0f396994ce41e6e5be947cbd Mon Sep 17 00:00:00 2001
From: Kroese <kroese@users.noreply.github.com>
Date: Mon, 20 Jul 2026 14:47:42 +0200
Subject: [PATCH] fix: Resolve shellcheck warnings (#97)

---
 .github/workflows/check.yml | 45 ++++++++++++++++++++-----------------
 Dockerfile                  |  3 ++-
 2 files changed, 27 insertions(+), 21 deletions(-)

diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
index 00448cc..ef4fa6b 100644
--- a/.github/workflows/check.yml
+++ b/.github/workflows/check.yml
@@ -1,5 +1,7 @@
 on: [workflow_call]
+
 name: "Check"
+
 permissions: {}
 
 jobs:
@@ -7,24 +9,27 @@ jobs:
     name: shellcheck
     runs-on: ubuntu-latest
     steps:
-    - 
-      name: Checkout code
-      uses: actions/checkout@v7
-    - parallel:
       -
-        name: Run ShellCheck
-        uses: ludeeus/action-shellcheck@master
-        env:
-          SHELLCHECK_OPTS: -x --source-path=src -e SC2114 -e SC2129 -e SC2034 -e SC1087 -e SC2317 -e SC2046
-      -
-        name: Lint Dockerfile
-        uses: hadolint/hadolint-action@v3.3.0
-        with:
-          dockerfile: Dockerfile
-          ignore: DL3008,DL3018,DL3020,DL3029,DL3059,DL4006,DL4001,SC2114,DL3006,DL3027
-          failure-threshold: warning
-      -
-        name: Validate JSON and YML files
-        uses: GrantBirki/json-yaml-validate@v5.0.0
-        with:
-          yaml_exclude_regex: ".*\\kubernetes\\.yml$"
+        name: Checkout code
+        uses: actions/checkout@v7
+      - parallel:
+          -
+            name: Run ShellCheck
+            uses: ludeeus/action-shellcheck@master
+            env:
+              SHELLCHECK_OPTS: >-
+                -x
+                --source-path=src
+                -e SC2129
+                -e SC2034
+                -e SC2317
+          -
+            name: Lint Dockerfile
+            uses: hadolint/hadolint-action@v3.3.0
+            with:
+              dockerfile: Dockerfile
+              ignore: DL3008,DL3018,DL3020,DL3029,DL3059,DL4001,DL4006,DL3006
+              failure-threshold: warning
+          -
+            name: Validate JSON and YML files
+            uses: GrantBirki/json-yaml-validate@v5
diff --git a/Dockerfile b/Dockerfile
index 49d054b..256fe58 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -187,7 +187,8 @@ IUD
   sed -i "s|the Pxvirt Powered by Lierfang\.|Proxmox for Docker v${VERSION_ARG}.|g" /usr/bin/pvebanner
 
   # Remove kernel modules and boot files — useless in a container (~960 MB)
-  rm -rf /usr/lib/modules /boot
+  rm -rf /usr/lib/modules
+  find /boot -mindepth 1 -delete
 
   # Remove hardware firmware blobs — no physical hardware in a container (~520 MB)
   rm -rf /usr/lib/firmware